> On Nov. 6, 2015, 3:29 p.m., Nick Shaforostoff wrote: > > src/declarative/holidayregionsmodel.cpp, line 81 > > <https://git.reviewboard.kde.org/r/125965/diff/1/?file=415523#file415523line81> > > > > i suggest enclosing strings into QByteArrayLiteral. > > > > see http://woboq.com/blog/qstringliteral.html for explanation and > > https://gitlab.com/pteam/pteam-qtbase/commit/05663e29d047851adb9a1ef440fb78b38ff3cc9b > > for the case when QBAL are not suitable > > Martin Klapetek wrote: > Is QByteArrayLiteral available in Qt 5.4? I can't find any info about it > anywhere. > > David Faure wrote: > Anywhere? You know qtbase.git right? :-) > Yes QByteArrayLiteral is available in 5.4, it is as old as QStringLiteral > (i.e. in 5.0.0 already, see qtbase ad35a41739c8e1fb6db62ed37b764448b2e59ece). > The difference is that it's not documented, however, not sure why.
I admit I don't have a Qt checkout on my disk since I stopped building it myself but yeah, should have looked there :) Will push a fix then. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125965/#review88099 ----------------------------------------------------------- On March 16, 2016, 10:24 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125965/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 10:24 p.m.) > > > Review request for KDE Frameworks and John Layt. > > > Repository: kholidays > > > Description > ------- > > For now it contains just the model of holiday regions > which will be used in the Plasma calendar events > configuration. > > > Diffs > ----- > > CMakeLists.txt e8b7970 > src/CMakeLists.txt c067b6c > src/declarative/CMakeLists.txt PRE-CREATION > src/declarative/holidayregionsmodel.h PRE-CREATION > src/declarative/holidayregionsmodel.cpp PRE-CREATION > src/declarative/kholidaysdeclarativeplugin.h PRE-CREATION > src/declarative/kholidaysdeclarativeplugin.cpp PRE-CREATION > src/declarative/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125965/diff/ > > > Testing > ------- > > Applet configuration contains proper list of available > holiday regions. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
