----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127448/#review93825 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On March 21, 2016, 3:50 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127448/ > ----------------------------------------------------------- > > (Updated March 21, 2016, 3:50 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kpackage > > > Description > ------- > > right now, to install a package from a tarball, you create an invalid package > instance and then use its install method. > we don't know for sure what will be its final installation path, and is not > easy to know it (one can blindly connect to the private > PackageJob::installPathChanged, but that's an hack) > With this patch, the invalid instance used as installer, will load the > package itself when the install job is finished, so if you connect to its > finished signal, you are guaranteed the package instance is directly usable > after that (provided the job didn't have any fatal errors) > > > Diffs > ----- > > autotests/plasmoidpackagetest.cpp eeaa0a3 > src/kpackage/package.h 4ff4c70 > src/kpackage/packagestructure.cpp accc5d1 > src/kpackage/private/packagejob.cpp 76614a0 > src/kpackage/private/packagejob_p.h acafa5e > > Diff: https://git.reviewboard.kde.org/r/127448/diff/ > > > Testing > ------- > > autotest included > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
