> On March 28, 2016, 8:22 p.m., Sven Brauch wrote: > > Hmm. Do we really need code for that? Can't you simply assign those buttons > > to the forward / backward actions as shortcuts? Try setting them as > > alternate shortcuts by default. > > Anthony Fieroni wrote: > This code is needed. QKeySequence is about *only* for keyboard keys. > Mouse buttons *must* me handled by event, as far i know. > > Sven Brauch wrote: > Did you actually try that in the shortcut dialog? Please do. I don't have > a mouse with extra keys here right now ... > > Kai Uwe Broulik wrote: > Just tried, I cannot assign any mouse buttons to shortcuts, including > back/forward. > > Anthony Fieroni wrote: > Not only try, i saw the code in kxmlgui who set this shortcuts. It's used > QKeySequence who is keyboard specific. You can see the same code as this > patch in Dolphin for for/backward.
Hmm, ok then. I'm undecided, let's wait for a few other opinions. On the one hand, it sounds sensible, on the other hand I don't like hardcoded shortcuts and the use case to switch documents with mouse is ... not a huge one imo. Code looks ok. - Sven ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127122/#review94084 ----------------------------------------------------------- On March 28, 2016, 8:20 p.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127122/ > ----------------------------------------------------------- > > (Updated March 28, 2016, 8:20 p.m.) > > > Review request for Kate, KDE Frameworks, Christoph Cullmann, Dominik Haumann, > and Kåre Särs. > > > Repository: kate > > > Description > ------- > > Show prev/next tab on mouse back/forward buttons > > > Diffs > ----- > > kate/katemainwindow.h ece0db8 > kate/katemainwindow.cpp f630e28 > > Diff: https://git.reviewboard.kde.org/r/127122/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
