----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127605/#review94391 -----------------------------------------------------------
https://git.reviewboard.kde.org/r/127251/ - Kai Uwe Broulik On April 7, 2016, 3:58 nachm., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127605/ > ----------------------------------------------------------- > > (Updated April 7, 2016, 3:58 nachm.) > > > Review request for KDE Frameworks. > > > Repository: kunitconversion > > > Description > ------- > > The current code uses waitForReadyRead on a QNetworkReply which simply > doesn't exist and always returns false. > I don't see how this code could have ever worked. > > > Diffs > ----- > > src/currency.cpp 3b99644a4d32433c074080ab91d92466a6ccc3a9 > > Diff: https://git.reviewboard.kde.org/r/127605/diff/ > > > Testing > ------- > > Ran krunner - finally got valid results > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
