> On April 18, 2016, 11:05 a.m., Gleb Popov wrote: > > Let's do something about this. I see two solutions for this: > > > > - Add another macro. If we go this route, can we put it in the same .cmake > > file? > > - Add a keyword parameter to the existing macro. Because macro uses > > `${ARGN}` it shouldn't break anything.
@dfaure: Do you think this issue should be fixed in Qt itself? I've just found http://stackoverflow.com/questions/33874243/qprocessstartdetached-but-hide-console-window which supports Patrick's remarks about "how we did it in KDE4 times". * We use `QProcess:startDetached` in KF5, in combination with "KDE_FORK_SLAVES" (=> causes console win) * We've been leaking QProcess and used `QProcess::start` in KDE4 times for 'kdeinit4.exe' (=> no console win). I haven't looked at the Windows implementation of QProcess yet, but maybe it's feasible to extend `QProcess::startDetached`? Ideas? Opinions? /me wonders why noone bothered fixing this in Qt itself yet (lots of discussions about the issues in forums) - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/#review94684 ----------------------------------------------------------- On Dec. 3, 2015, 8 a.m., Kevin Funk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124905/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2015, 8 a.m.) > > > Review request for KDE Frameworks, Alex Merry and David Faure. > > > Repository: kio > > > Description > ------- > > Win: Hide console window for binaries in LIBEXEC > > > Diffs > ----- > > src/ioslaves/http/CMakeLists.txt 76a8e2800b84c312431cc1996ac81d1ef6fb5cfc > src/ioslaves/http/kcookiejar/CMakeLists.txt > 7b4778d1f67c1ad9f9edcaa4692b39ee6fe3f365 > src/kioexec/CMakeLists.txt 91284a3a61b86770b4d1939da52d256840803608 > src/kioslave/CMakeLists.txt e02febd380b268c596e8ecc3b745b6f50993ab4e > src/kpac/CMakeLists.txt fc5989714480ca49b5bd72e1c7b458b26bd0d9bc > > Diff: https://git.reviewboard.kde.org/r/124905/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Funk > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel