On Sat, Apr 23, 2016 at 8:35 PM, Martin Graesslin <mgraess...@kde.org> wrote: > On Saturday, April 23, 2016 1:09:00 PM CEST Ben Cooksley wrote: >> On Sat, Apr 23, 2016 at 1:04 PM, Daniel Vrátil <dvra...@kde.org> wrote: >> > On Saturday, April 23, 2016 1:44:16 AM CEST Ben Cooksley wrote: >> >> On Fri, Apr 22, 2016 at 11:11 PM, David Faure <fa...@kde.org> wrote: >> >> > On Thursday 21 April 2016 14:57:52 no-re...@kde.org wrote: >> >> >> GENERAL INFO >> >> >> >> >> >> BUILD UNSTABLE >> >> >> Build URL: >> >> >> https://build.kde.org/job/kdbusaddons%20master%20kf5-qt5/PLATFORM=Linu >> >> >> x, >> >> >> compiler=gcc/11/> >> >> > >> >> > Wow, ASAN detected a real bug in Qt here. >> >> > >> >> > Fixed in https://codereview.qt-project.org/156728 >> >> >> >> As this issue essentially breaks any test on the CI system that >> >> depends on Qt I suggest all developers affected by this indicate this >> >> on the relevant reviews. >> > >> > Hey guys, >> >> Hi David, >> >> > any chance to get this patch into our Qt build on the CI since it has been >> > integrated upstream now? As it affects all tests that interact with DBus >> > it >> > would be nice to resolve this on the CI. >> >> We'll need upstream to update qt5.git (I think that's still required >> for changes to fully flow through) I think. >> We could try to hack the patch in, but then we'll end up having to >> undo that in a few weeks time. > > Could we disable that ASAN check please[1]? I have two of my projects failing > due to the DBus problem and one further failing due to a similar problem in > QQuickStyleItem [2]. It's nice that we find errors, but I rather not have my > tests fail due to errors in Qt.
That would just cover up the issue. Also, it isn't that simple, as we already export ASAN_OPTIONS with a different value, and changing that will break quite a lot more. If QQuickStyleItem is broken as well, then the Qt developers need to be asked to fix that as well then. If it is that much of an issue, I suggest we simply do away with ASAN testing altogether, as if our upstreams aren't going to bother with it, it makes it pointless for us. > > Cheers > Martin Regards, Ben > > [1] just export ASAN_OPTIONS=new_delete_type_mismatch=0 > [2] https://build.kde.org/user/graesslin/my-views/view/mgraesslin > %20maintained/job/plasma-integration%20master%20kf5-qt5/ > PLATFORM=Linux,compiler=gcc/lastCompletedBuild/testReport/%28root%29/ > TestSuite/frameworkintegration_kfiledialogqml_unittest/ _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel