> On Май 3, 2016, 1:49 след обяд, David Edmundson wrote: > > src/plasma/dataengine.cpp, line 573 > > <https://git.reviewboard.kde.org/r/127795/diff/4/?file=464040#file464040line573> > > > > should this line still be here? > > Anthony Fieroni wrote: > dataengine.cpp:305 and 319 is emitted, so this slot is called after that, > it's duplicate.
Even 304, 316 source is removed from container, this slot must not present, it's useless - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127795/#review95130 ----------------------------------------------------------- On Май 3, 2016, 7:10 преди обяд, Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127795/ > ----------------------------------------------------------- > > (Updated Май 3, 2016, 7:10 преди обяд) > > > Review request for KDE Frameworks and Marco Martin. > > > Repository: plasma-framework > > > Description > ------- > > ^^ > > > Diffs > ----- > > autotests/pluginloadertest.h 61fc963 > autotests/pluginloadertest.cpp 4f96780 > src/plasma/dataengine.cpp f942926 > > Diff: https://git.reviewboard.kde.org/r/127795/diff/ > > > Testing > ------- > > Test pass. > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel