> On May 4, 2016, 11:45 p.m., Albert Astals Cid wrote: > > +1 would i'd like someone else opinion.
Ping? - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127817/#review95188 ----------------------------------------------------------- On May 3, 2016, 1:09 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127817/ > ----------------------------------------------------------- > > (Updated May 3, 2016, 1:09 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kiconthemes > > > Description > ------- > > We were using oxygen as the default theme, this meant that oxygen was > processed by every application. This was fixed in the past by changing this > setting to `breeze`, but this only brought new kinds of problems (e.g. review > 127232). > > See bug 336739, bug 360664. > > By just using hicolor, we don't make the application fetch `oxygen` for > little reason. > > > Diffs > ----- > > src/kiconloader.cpp 6ce7ecdc0b9c38647994c750e77980fbf9b6fdd4 > src/kicontheme.cpp f8c0a37754848a74e42bba5866aa4ce0998bce7c > > Diff: https://git.reviewboard.kde.org/r/127817/diff/ > > > Testing > ------- > > On dolphin: > This has an improvement on callgrind 1556M/1185M instructions (30% > improvement). > KIconLoader allocations correspond to 3.8% instead of 4.8%, going down by: > 535K/509K > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
