> On Mai 12, 2016, 3:59 nachm., David Edmundson wrote: > > kcmshell/main.cpp, line 95 > > <https://git.reviewboard.kde.org/r/127899/diff/1/?file=464663#file464663line95> > > > > this line is already doing it. > > > > bool KService::noDisplay() const > > ... > > if (!KAuthorized::authorizeControlModule(storageId())) { > > return true; > > } > > David Edmundson wrote: > I'm a bit confused. You said "you could still open them" but you've also > written you've not tested it. > > If you have tried blocking it them and it's not working, can you show me > your config file?
As I said, no testing :D I just grepped the code of KCMShell for KAuthorized and only found that one occurence in --list, my statement was based on that. So, we're all set \o/ What's interesting, though, is that KService uses storageId while KCMShell uses menuId() - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127899/#review95424 ----------------------------------------------------------- On Mai 12, 2016, 1:59 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127899/ > ----------------------------------------------------------- > > (Updated Mai 12, 2016, 1:59 nachm.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kde-cli-tools > > > Description > ------- > > This makes KCMShell skip loading modules that are restricted in KDE Control > Module Restrictions. > > The --list property already filtered them but you could still open them. > > > Diffs > ----- > > kcmshell/main.cpp 3a4f651 > > Diff: https://git.reviewboard.kde.org/r/127899/diff/ > > > Testing > ------- > > Literally none. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel