----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127900/#review95439 -----------------------------------------------------------
src/atticabasejob.cpp (line 60) <https://git.reviewboard.kde.org/r/127900/#comment64708> Get `m_reply->attribute(QNetworkRequest::RedirectionTargetAttribute).toUrl()` into a variable? also space in `if_(` src/atticabasejob.cpp (line 63) <https://git.reviewboard.kde.org/r/127900/#comment64709> remove commented code. src/atticabasejob.cpp (line 65) <https://git.reviewboard.kde.org/r/127900/#comment64710> `} else {` - Aleix Pol Gonzalez On May 12, 2016, 7:17 p.m., Andreas Cord-Landwehr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127900/ > ----------------------------------------------------------- > > (Updated May 12, 2016, 7:17 p.m.) > > > Review request for KDE Frameworks, Cornelius Schumacher and Kevin Funk. > > > Bugs: 354748 > http://bugs.kde.org/show_bug.cgi?id=354748 > > > Repository: attica > > > Description > ------- > > Redirection only worked with relative urls. Yet, e.g. the http to https > redirection on KDE servers uses absolute paths, which resulted in an > empty url, since the reply attribute was not relative. > > This patch adds a case distinction for redirecting absolut and relative > paths. > > BUG: 354748 > > > Diffs > ----- > > src/atticabasejob.cpp f73cb432212be63cff2ae1118c602cc3bae6d615 > > Diff: https://git.reviewboard.kde.org/r/127900/diff/ > > > Testing > ------- > > Manual testing with GHNS for documentation in KDevelop. > > > Thanks, > > Andreas Cord-Landwehr > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
