----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127887/#review95561 -----------------------------------------------------------
src/core/installation.cpp (line 382) <https://git.reviewboard.kde.org/r/127887/#comment64748> I don't know if this does the same but also didn't test. src/kmoretools/kmoretoolsconfigdialog_p.cpp (line 201) <https://git.reviewboard.kde.org/r/127887/#comment64749> I wonder why here "for" is better than Q_FOREACH. - Gregor Mi On May 11, 2016, 11:01 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127887/ > ----------------------------------------------------------- > > (Updated May 11, 2016, 11:01 p.m.) > > > Review request for KDE Frameworks and Jeremy Whiting. > > > Repository: knewstuff > > > Description > ------- > > Mostly clazy fixes, few cleanups > > > Diffs > ----- > > src/core/installation.cpp 1887d0f > src/kmoretools/kmoretools.h 32da22c > src/kmoretools/kmoretools.cpp 8bd6751 > src/kmoretools/kmoretoolsconfigdialog_p.cpp 466b887 > src/kmoretools/kmoretoolsmenufactory.cpp aad3f00 > src/kmoretools/kmoretoolspresets.cpp 679e849 > src/staticxml/staticxmlprovider.cpp 541bf57 > src/ui/itemsviewdelegate.cpp 7001be2 > tests/kmoretools/kmoretoolstest_interactive.cpp b1cbdea > > Diff: https://git.reviewboard.kde.org/r/127887/diff/ > > > Testing > ------- > > Builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
