> On May 21, 2016, 10:20 p.m., Kåre Särs wrote: > > CMakeLists.txt, line 12 > > <https://git.reviewboard.kde.org/r/127896/diff/3/?file=465312#file465312line12> > > > > Why is this not: option(DISABLE_DBUS "Remove..." OFF) ? > > > > For the rest I'm happy :)
Idem. Isn't there a guideline against negative options? IOW, wouldn't it be better to have something like `option(INCLUDE_DBUS_SUPPORT "Include support for using DBus to ..." ON)` so that you don't have to test on `NOT FOO` everywhere? (I know it's common practice to use shortcuts like "--disable-dbus" to indicate "disable support for dbus", but we can just as well use an option name that's semantically correct, no? :) ) - René J.V. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127896/#review95681 ----------------------------------------------------------- On May 20, 2016, 11:13 p.m., Nick Shaforostoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127896/ > ----------------------------------------------------------- > > (Updated May 20, 2016, 11:13 p.m.) > > > Review request for KDE Software on Mac OS X, KDE Frameworks, David Edmundson, > and Martin Gräßlin. > > > Repository: kauth > > > Description > ------- > > this is the first patch to make kde frameworks build (and then work) without > dbus. > > this will allow homebrew users use precompiled vanilla Qt to build kde apps > on osx. as dbus is not a common service in osx world, kde apps on osx should > use native means for interprocess communication instead -- this will make > them better citizens in osx ecosystem. > > > Diffs > ----- > > CMakeLists.txt 48dc2d9 > autotests/BackendsManager.cpp 59675b3 > autotests/CMakeLists.txt b53d760 > autotests/HelperTest.cpp 8050a06 > src/CMakeLists.txt 1b6930d > src/ConfigureChecks.cmake d46761a > > Diff: https://git.reviewboard.kde.org/r/127896/diff/ > > > Testing > ------- > > compiles fine on osx, compiles fine on linux, tests on linux still pass. > > > Thanks, > > Nick Shaforostoff > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
