----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128055/#review96041 -----------------------------------------------------------
Ship it! Ship It! - David Faure On May 30, 2016, 1:17 p.m., Wolfgang Bauer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128055/ > ----------------------------------------------------------- > > (Updated May 30, 2016, 1:17 p.m.) > > > Review request for KDE Frameworks, Plasma and David Faure. > > > Bugs: 356237 > https://bugs.kde.org/show_bug.cgi?id=356237 > > > Repository: kde-cli-tools > > > Description > ------- > > QStandardDirs::writableLocation() doesn't guarantee that the returned > directory actually exists. > So create it, otherwise saving the changes will fail if it isn't there. > > > Diffs > ----- > > keditfiletype/mimetypewriter.cpp 11963d2 > > Diff: https://git.reviewboard.kde.org/r/128055/diff/ > > > Testing > ------- > > Delete ~/.local/share/mime/packages/ or ~/.local/share/mime/, if they exist. > Enter the file types editor and modify a file type (e.g. add/change the > icon), then press OK or Apply. > Close it and open it again. > > The changes are still there now, before they were not applied and reverted to > the system defaults. > > > Thanks, > > Wolfgang Bauer > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel