> On June 27, 2016, 12:16 p.m., Thomas Pfeiffer wrote: > > Thank you for implementing the suggestion! > > There are still some issues with it: > > 1. HIG says "Avoid using color as a primary method of communication". A > > red-green blind person would have no tell success apart from failure here. > > Please write "Checksums match" or "Checksums do not match" below. > > 2. A test I just did with a "regular" user showed that she did not know > > what to do with the verification box. I'd suggest writing above it "Copy > > and paste a checksum provided for example on the website you downloaded the > > file from in the field below." > > 3. It would be great if you could insert an expander which shows further > > instructions if the checksums don't match, e.g. "This may be due to a > > faulty download. Try re-downloading the file. If the verification still > > fails, contact the source of the file." > > 4. What happens if you type the checksum in manually? At witch point does > > it start verifying? > > Elvis Angelaccio wrote: > > What happens if you type the checksum in manually? At witch point does > it start verifying? > > It starts as soon as the input is a valid MD5, SHA1 or SHA256 checksum > (which means 32, 40 or 64 hexadecimal digits). If it's not valid, the box > becomes red and a tooltip explains what's wrong. I'm assuming that most of > the times the user is going to copy-paste the whole checksum. > > > It would be great if you could insert an expander which shows further > instructions if the checksums don't match, e.g. "This may be due to a faulty > download. Try re-downloading the file. If the verification still fails, > contact the source of the file." > > An expander should be doable (using KCollapsibleGroupBox), but if we're > going to add a label "Checksums do not match", why not just adding another > label below? (with the expanded error message). There is more than enough > space in the dialog.
It might look a bit "cleaner" with an expander, but you are right, we have the space and it's not like people have to see the whole thing that often, so it's fine. I think we might have made checksum checking actually usable for normal people :) (if they know where to find it, that is) - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review96893 ----------------------------------------------------------- On June 27, 2016, 3:46 p.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128283/ > ----------------------------------------------------------- > > (Updated June 27, 2016, 3:46 p.m.) > > > Review request for KDE Frameworks, KDE Usability and David Faure. > > > Repository: kio > > > Description > ------- > > This patch adds a Checksums tab in the properties dialog, where the user can > retrieve and verify the most popular checksum algorithms (md5, sha1 and > sha256). > > To simplify the implementation, the checksums are computed as soon as the > user opens the dialog. This can take a while if the file is huge (in > particular with sha256), but the computation happens in another thread and in > practice this should not be a performance problem. > > The tab is available only for readable local files (no simlinks) and only > when there is a single selection. > > Please note that some of the labels in the screenshots are clipped due to a > bug in breeze: https://bugs.kde.org/show_bug.cgi?id=364426 > > > Diffs > ----- > > src/widgets/CMakeLists.txt f906577 > src/widgets/checksumswidget.ui PRE-CREATION > src/widgets/kpropertiesdialog.cpp d0a2faa > src/widgets/kpropertiesdialog_p.h c01554e > > Diff: https://git.reviewboard.kde.org/r/128283/diff/ > > > Testing > ------- > > * Check whether the computed values match the values from md5sum, sha1sum, > sha256sum. > * Check whether the line edits get a green background if the computed and > expected values match. > * Check whether the line edits get a red background if the computed and > expected values differ. > > > File Attachments > ---------------- > > MD5 ready to be shared > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/26/b882fad9-85b0-4250-9743-3549339e6718__Spectacle.l10844.png > Default dialog > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/ad06e136-7ce3-4876-a594-98fbc64f5538__Spectacle.M13222.png > Mismatch > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/99838e45-d9c5-4a14-b26a-9440f0249c4b__Spectacle.V13222.png > Match > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/519fa28f-7c7d-4bb4-bd24-622d18d7f2e2__Spectacle.v13222.png > Invalid checksum > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/a243c830-2dc0-4cbd-95e9-8f1684bc86a4__Spectacle.J13336.png > > > Thanks, > > Elvis Angelaccio > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel