----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128406/#review97442 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On July 9, 2016, 11:55 a.m., Ragnar Thomsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128406/ > ----------------------------------------------------------- > > (Updated July 9, 2016, 11:55 a.m.) > > > Review request for KDE Frameworks, David Edmundson and Elvis Angelaccio. > > > Repository: kwidgetsaddons > > > Description > ------- > > We are using KCollapsibleGroupBox in Ark and stumbled upon a segfault in an > autotest involving this widget (see backtrace > [here](https://paste.kde.org/pwcohd64z)). It looks like QTimeLine::stop() > gets called after KCollapsibleGroupBox is deleted. This causes > QTimeLine::stateChanged to get emitted which then calls > KCollapsibleGroupBox::updateChildrenVisibility() that causes the crash. > > To see the crash, clone the newAddDialog branch of Ark and run the autotests. > > This diff calls QTimeLine::stop() in the KCollapsibleGroupBox dtor if it is > running, before deleting the d pointer. > > > Diffs > ----- > > autotests/CMakeLists.txt 4be2eaf > autotests/kcollapsiblegroupbox_test.h PRE-CREATION > autotests/kcollapsiblegroupbox_test.cpp PRE-CREATION > src/kcollapsiblegroupbox.cpp 0c3f866 > > Diff: https://git.reviewboard.kde.org/r/128406/diff/ > > > Testing > ------- > > The autotests in newAddDialog branch of Ark pass with this diff. > > > Thanks, > > Ragnar Thomsen > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
