----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128477/ -----------------------------------------------------------
Review request for KDE Frameworks and Gleb Popov. Repository: kio Description ------- Some tests for kio try to move system relevant files&paths with the blind assumption that the permissions to touch these files is not present. The files are - /etc/passwd - /etc/cups - /etc - /boot [sic!]. Check that the process does not actually have the rights to touch system relevant files when running the - TestTrash::trashDirectoryOwnedByRoot - TestTrash::trashFileOwnedByRoot - JobTest::moveFileNoPermissions - JobTest::moveDirectoryNoPermissions tests -- and bail out of them if so. This patch probably still needs some more work [maybe I also missed another naughty test?], and I welcome every kind of input on it (apart from the straw man *don't run tests as root* ;) ). Diffs ----- autotests/jobtest.cpp 579c507 src/ioslaves/trash/tests/testtrash.cpp c71df13 Diff: https://git.reviewboard.kde.org/r/128477/diff/ Testing ------- Without patch: - enjoying two hours of restoring a system without /etc & /boot With patch: - grep 'must not' Testing/Temporary/LastTest.log.tmp SKIP : TestTrash::trashFileOwnedByRoot() Test must not be run by root. SKIP : TestTrash::trashDirectoryOwnedByRoot() Test must not be run by root. SKIP : JobTest::moveFileNoPermissions() Test must not be run by root. SKIP : JobTest::moveDirectoryNoPermissions() Test must not be run by root. Thanks, Tobias Berner
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel