----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/ -----------------------------------------------------------
(Updated July 21, 2016, 1:37 p.m.) Review request for KDE Frameworks and Plasma. Changes ------- Updated to use the manual deletion rather than QSGTexture's deletion. I didn't push this earlier because I uploaded this at a time where we had a completely unrelated crash in WindowsThumbnail and someone said this makes it worse. Which is possible, but also unrelated. I'm bumping it now because I went through a bug report (https://bugs.kde.org/show_bug.cgi?id=365946) where it seems this is the cause and it reminded me of it. Repository: plasma-framework Description ------- The QSGTextures are created with window()->createTextureFromId(m_texture, QSize(w,h), QuickWindow::TextureOwnsGLTexture)); this means we don't want to be deleting textures ourselves too, it will be deleted when we delete the QSGTexture, which is a scoped pointer inside our QSGNode. BUG: 355644 REVIEW: Diffs (updated) ----- src/declarativeimports/core/windowthumbnail.cpp 6c46789b13411fe311c4d3fb60c690abd966cc38 Diff: https://git.reviewboard.kde.org/r/126131/diff/ Testing ------- Thanks, David Edmundson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
