> On July 21, 2016, 6:44 a.m., David Faure wrote: > > Porting bug indeed, the kdelibs4 code said KDE::lstat(dest_orig, &buff_orig) > > Good catch! > > > > (This shows a missing unittest though)
commit it on my behalf :) - Chinmoy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128492/#review97688 ----------------------------------------------------------- On July 21, 2016, 3:34 a.m., Chinmoy Ranjan Pradhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128492/ > ----------------------------------------------------------- > > (Updated July 21, 2016, 3:34 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > This fixes a typo in file ioslave source. > Before initiating a put job the existence of the original file is checked. > But the path of '.part' file is passed as argument instead of path of the > original file. As a result a put job is initiated even though the file exist. > > The Error Message: > When user tries to create a new file with an existing name, the following > error message shows up. Instead of saying that the file with the given name > exist, the error says can't rename partial file. > > > Diffs > ----- > > src/ioslaves/file/file.cpp 9a8ca32 > > Diff: https://git.reviewboard.kde.org/r/128492/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > the error message > > https://git.reviewboard.kde.org/media/uploaded/files/2016/07/21/70053ddf-d72d-4ffe-936a-c38068de5d0d__erroemessage.png > > > Thanks, > > Chinmoy Ranjan Pradhan > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
