----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/#review97745 -----------------------------------------------------------
Looks good expect for the unrelated change src/filewidgets/knewfilemenu.cpp (line 289) <https://git.reviewboard.kde.org/r/128499/#comment65839> This change belongs to another commit. - David Faure On July 22, 2016, 6:35 a.m., Chinmoy Ranjan Pradhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128499/ > ----------------------------------------------------------- > > (Updated July 22, 2016, 6:35 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > When creating a new file, if a file with the default name already exist then > a new name is suggested by KIO::suggestName. Now this works fine until the > scheme of file's url is "file" but in case the scheme is "desktop" (like when > the url in dolphin is set to desktop:/ or "Folder View Settings > Location" > is set to desktop:/) then the check for file's existence fails because > QFile::exists doesn't understand the "desktop" scheme. So KIO::suggestName is > not called and no new filename is suggested in case a file with the same > filename already exist. To fix this i used KNewFileMenuPrivate::mostLocalUrl > in KNewFileFileMenu::executeRealFileorDir which will resolve "desktop:/" to > the user's desktop path. > > > Diffs > ----- > > src/filewidgets/knewfilemenu.cpp 2e613b1 > > Diff: https://git.reviewboard.kde.org/r/128499/diff/ > > > Testing > ------- > > > Thanks, > > Chinmoy Ranjan Pradhan > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
