> On Aug. 10, 2016, 4:52 nachm., Kevin Funk wrote: > > I'm late to the party, but ...: This won't fly on Windows (at least under > > MSVC). I'm not usually compiling kfilemetadata.git on Windows, so I wasn't > > affected by this change thus didn't notice. > > > > Can we make the dependency on xattr optional so we can restore the build > > with MSVC?
Sure but I'm not very knowledgeable in CMake and don't have a Windows machine, so don't expect me to do it :) - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127023/#review98302 ----------------------------------------------------------- On Feb. 26, 2016, 7:56 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127023/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 7:56 nachm.) > > > Review request for KDE Frameworks, KDEPIM, Daniel Vrátil, Sebastian Kügler, > and Vishesh Handa. > > > Repository: kfilemetadata > > > Description > ------- > > This adds support for the user.xdg.origin.email.subject, > user.xdg.origin.email.sender, user.xdg.origin.email.message-id xattrs [1] to > KFileMetadata. > > This can (should :P) be populated by KMail when you save an attachment. > > Not too happy about the "displayName" I chose. Also we'll need to figure out > what to index and how we can relate this information and present it to the > user in a meaningful way. But at least let's collect the information first > and then we can think about ways to handle this. > > [1] https://wiki.freedesktop.org/www/CommonExtendedAttributes/ > > > Diffs > ----- > > src/properties.h 6ceaca5 > src/propertyinfo.cpp 4d1fac4 > src/usermetadata.h 9e10d2a > src/usermetadata.cpp 5485d0e > > Diff: https://git.reviewboard.kde.org/r/127023/diff/ > > > Testing > ------- > > Not really. Tests pass, though. > > > Thanks, > > Kai Uwe Broulik > >