> On Aug. 12, 2016, 9:37 a.m., David Faure wrote: > > I don't feel confident about this change, for lack of unit tests. > > > > Please add unittests near kio_desktop (not in kio, which can't use > > kio_desktop). > > You can use my (new) tests in kio's jobtest.cpp as starting point: > > void createSymlink(); > > void createSymlinkAsShouldSucceed(); > > void createSymlinkAsShouldFail(); > > and add tests for any other code path you see in your code. > > Chinmoy Ranjan Pradhan wrote: > I think a much simpler way would be to overload kio::link. What do you > say?
I don't follow, please expand your thought. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128618/#review98236 ----------------------------------------------------------- On Aug. 9, 2016, 3:20 p.m., Chinmoy Ranjan Pradhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128618/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2016, 3:20 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > KIO::link creates symlink when either protocol+host+port+username+password of > the source and the link are same or the link is going to be created locally. > In case of plasma's folder view none of the above cases are true therefore > creating a symlink in folder view plasmoid gives an error. > This patch aims to fix this issue. > > > Diffs > ----- > > src/core/copyjob.cpp 8d6ab05 > > Diff: https://git.reviewboard.kde.org/r/128618/diff/ > > > Testing > ------- > > All tests pass. > > > File Attachments > ---------------- > > error message > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png > > > Thanks, > > Chinmoy Ranjan Pradhan > >
