----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128609/#review98405 -----------------------------------------------------------
Ship it! I guess it would make sense to update the khelpmenu code to use this new function? - Albert Astals Cid On Aug. 8, 2016, 9:06 a.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128609/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2016, 9:06 a.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kconfigwidgets > > > Description > ------- > > Donate action has been recently added to kxmlgui's Help menu: > https://quickgit.kde.org/?p=kxmlgui.git&a=commit&h=5ff477302d816d341f1a38009f74ac4ebb3214dd > > This patch adds support for it in KStandardAction. This will help e.g. > Dolphin to show the Donate action in its custom "control" menu. > > > Diffs > ----- > > src/kstandardaction.h c628066d043f9be98c1c18fd66bf227099d695d5 > src/kstandardaction.cpp 40f63c4df0534e4bd1069565cf4837960ed379bc > src/kstandardaction_p.h 814374e0b7ed3939c8a80a26e59f461ef73e22c0 > > Diff: https://git.reviewboard.kde.org/r/128609/diff/ > > > Testing > ------- > > Needs https://git.reviewboard.kde.org/r/128608/ to build. > > > Thanks, > > Elvis Angelaccio > >