> On Aug. 25, 2016, 1:59 a.m., Christoph Feck wrote: > > Ping? Can someone please review? It already missed the tr deadline for > > 5.26, but maybe we can get this into 5.27.
As far as I understand the change it will show tofu'ed characters in their intended appearance (the example is misleading here) but disable the item so it looks differently and cannot be selected. * The dialog is quite confusing right now. Since the font name is selected after this pseudo-hierarchical organization, along with the font size that is rather a zoom, I would say adding another button is not diminishing the overall UX. Users will basically search and not browse all the fancy characters. And I agree that a split- or menu button is not needed. * The icon have to be something else, of course. You may ask Andreas Kainz for that. * For the text you could say "Highlight applicable characters" and "The currently selected font may not include all unicode characters, which will be dimmed when this option is checked.". But take this as just an idea. * Btw: What will be the default? Suggest On. * Code: - + What happens when you search for something with having the dim feature enabled? I recommend to also not hide but dim those results. + How do you discriminate the non-applicable chars from the non-printable? o Today I can select the alien chars and add them to the clipboard. Perhaps my target has a different font and for some reason I don't want to change it. This workflow will not be supported anymore when the items are disabled. Very far-fetched workflow, however. Just to mention. - Heiko ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128680/#review98615 ----------------------------------------------------------- On Aug. 15, 2016, 3:12 a.m., Christoph Feck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128680/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2016, 3:12 a.m.) > > > Review request for KDE Frameworks and KDE Usability. > > > Bugs: 97420 > https://bugs.kde.org/show_bug.cgi?id=97420 > > > Repository: kwidgetsaddons > > > Description > ------- > > Adds a toolbutton to the right of the font combobox to control the "font > merging" property of QFont. When selected, characters which are not available > in the font are dimmed (i.e. look disabled). > > Seeking feedback about: > - placement of the button > - used icon (currently "format-text-strikethrough"; it shows an S character > which could stand for "substitution") > - action name and tooltip (see line 477 and 479) > - and code changes ;) > > I was unsure if the toolbutton could have a popup menu showing three options: > 1) show characters from all fonts > 2) dim characters not available in font > 3) hide characters not available in font > > but I did not implement it, because it felt odd not being able to see _which_ > characters are not available in the font. > > > Diffs > ----- > > src/kcharselect.cpp 45c1e99 > > Diff: https://git.reviewboard.kde.org/r/128680/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Character table with font substitution (default) > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/7220dddb-ca1b-42a2-966c-791925156baf__snapshot1.png > Character table with dimming substituted characters > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/67c02866-b12c-4080-b6a4-22e29006448b__snapshot2.png > > > Thanks, > > Christoph Feck > >
