On Monday, 12 September 2016 09:10:46 CEST Jaroslaw Staniek wrote: > On 12 September 2016 at 08:04, Kevin Funk <kf...@kde.org> wrote: > > On Sunday, 11 September 2016 03:21:21 CEST Dominik Haumann wrote: > > > Hi all, > > > > > > I just saw a commit by Volker turning nullptr into Q_NULLPTR with the > > > comment that Visual Studio 2012 does not support nullptr. > > > > > > While this change is trivial for obvious reasons, do we really need to > > > do > > > that? > > > > I don't think so. > > > > nullptr is actually supported since VS2010 [1]. > > > > Some other remark: I think noone's using anything below VS2015 for testing > > KDE > > on Windows anyway. I'm expecting compilation to be broken on earlier > > versions > > of VS. > > I am not only testing but also using/depend on 2013, which has quite some > C++11 features already.
Alright, thanks for letting us know. > The builds of KF5 just work (this is not a CI, this > is building from time to time). Sometimes patching is needed here and there > because of completely unnecessary - for my context - dependency of > kdoctools. Things improved here in 2016 anyway. > > If not for other reasons, please note that people may depend on < 2015 > because some other component is not supported on 2015 or because od the > boss'/customer's request. > > I think fixing on a 'beeding edge' compiler may be not the best strategy, > yet I see no reason to be much less flexible in this regard than Qt is. VS2015 is no longer 'bleeding edge', it's at Update 3 already and in my experience it's a highly reliable version of VS to this date. That said, depending on VS2013 sounds fine to me of course. Cheers, Kevin > > Cheers, > > Kevin > > > > [1] http://en.cppreference.com/w/cpp/compiler_support for evidence > > > > > I am raising this question especially since KTextEditor seems to use > > > 'nullptr' in several locations now for several releases - and noone > > > complained. > > > > > > Are we supposed to turn nullptr in KTextEditor also into nullptr, or > > > can we take the liberty and ditch Q_NULLPTR completely for all > > > frameworks? > > > > > > Same also applies to 'override'. > > > > > > Best, > > > Dominik > > > > -- > > Kevin Funk | kf...@kde.org | http://kfunk.org -- Kevin Funk | kf...@kde.org | http://kfunk.org
signature.asc
Description: This is a digitally signed message part.
