----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128913/#review99187 -----------------------------------------------------------
I was surprised that we allow filenames with newlines in the first place. Shouldn't we use a server-side hook that prevents commits with broken filenames? Or this is only a problem with icons? - Elvis Angelaccio On Sept. 15, 2016, 8:17 a.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128913/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2016, 8:17 a.m.) > > > Review request for KDE Frameworks. > > > Repository: breeze-icons > > > Description > ------- > > there is no reason for why they should. packaging systems take offense. so > do I. > > > Diffs > ----- > > autotests/CMakeLists.txt 5c561c712322e1b90fdd2806ba4ce4011be2ad14 > autotests/newlinetest.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/128913/diff/ > > > Testing > ------- > > makes and fails current master since it has broken files > > > Thanks, > > Harald Sitter > >