----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128944/#review99392 -----------------------------------------------------------
src/lib/plugin/desktopfileparser.cpp (line 359) <https://git.reviewboard.kde.org/r/128944/#comment66897> if this compiles before and after, then you should set the defines that prevent implicit string conversions and fix all cases where this occurs - Milian Wolff On Sept. 20, 2016, 11:19 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128944/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2016, 11:19 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kcoreaddons > > > Description > ------- > > While analising plasmashell under heaptrack, one of the sore spots is > temporary allocations within DesktopFileParser. This improves the situation > by: > > * Only converting to QString/utf8 once. > * Using QStringRef instead of fully splitting QString to parse them. > > > Diffs > ----- > > src/lib/plugin/desktopfileparser.cpp 2eb198d > src/lib/plugin/desktopfileparser_p.h c61b297 > > Diff: https://git.reviewboard.kde.org/r/128944/diff/ > > > Testing > ------- > > tests still pass, plasma still works normally. > > heaptrack plasmashell: > > after: > allocations: 4169312 > leaked allocations: 83225 > temporary allocations: 606902 > > before: > allocations: 4680691 > leaked allocations: 84825 > temporary allocations: 819292 > > > Thanks, > > Aleix Pol Gonzalez > >