----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129019/#review99551 -----------------------------------------------------------
Ship it! One less reason for Dolphin to have its own context menu class ;) - Elvis Angelaccio On Sept. 26, 2016, 7:58 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129019/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 7:58 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > This was missing in KFileItemActions so apps had to implement > this by themselves (this particular implementation is inspired by Dolphin's, > while KonqPopupMenu only had support for .desktop files and not JSON > metadata). > > This API will also be useful in folderview (which I'm porting away > from KonqPopupMenu) and kfind (same strategy). > > > Diffs > ----- > > src/widgets/kfileitemactions.h 9b025549efdceef7f32dc461f3d5bfa2ee10d938 > src/widgets/kfileitemactions.cpp b31da0a38bfef634b0be207be9a87c9ba6864230 > src/widgets/kfileitemactions_p.h 3f669feb3cf54b61dcb7ad0a22bc005210e18899 > > Diff: https://git.reviewboard.kde.org/r/129019/diff/ > > > Testing > ------- > > Porting dolphin, folderview and kfind to this. Using KIO version checks of > course. > > > Thanks, > > David Faure > >