----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129086/ -----------------------------------------------------------
Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description ------- It's reasnoble to expect people to download an applet just before trying to change an existing applet using the alternatives system. Therefore doing the check that any alternative applets exist during applet initialisation time is semantically wrong as the option will be prematurely disabled. This patch moves it to be verified in contextualActionsAboutToShow. This patch also gives a startup performance boost. Loading all the applets metadata takes a small amount of time (~50 milliseconds) not really noticable when you're doing it once, but it adds up when we're doing it for a lot of applets in a row. Diffs ----- src/plasma/applet.cpp 5e278dc69055de0316b49decc08e471081e34b53 src/plasma/private/applet_p.cpp 0f37fe5e3a3c417e079f54b6d8b45fa0051684a5 Diff: https://git.reviewboard.kde.org/r/129086/diff/ Testing ------- Right click on kickoff, option was there and worked Right click on system tray, no option Locked widges, option wasn't there Unlocked widgets, option in kickoff came back Context menu still appears "instantly" Thanks, David Edmundson
