----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129275/ -----------------------------------------------------------
(Updated Oct. 30, 2016, 11:17 a.m.) Review request for KDE Frameworks and David Faure. Changes ------- Address issues Repository: kio Description ------- https://bugs.kde.org/show_bug.cgi?id=368314 seems to be an actual bug in KIO, rather than a regression in kwalletmanager. I reproduced the bug in a test case: basically `StoredTransferJob` fails to copy a QTemporaryFile when the file has been written by a QXmlStreamWriter (destination file is created, but empty). If we write to the temp file using a QTextStreamer instead, everything works as expected... Diffs (updated) ----- autotests/jobtest.h 5687b4a448d26d703d33603e5a0939bc4f8c77b4 autotests/jobtest.cpp 11bac4d51e97840181aff99fdddb92cdf4db1ba2 src/core/storedtransferjob.h 82ffe77eec9d37af3b3bad81a3515d31eb5d4e94 Diff: https://git.reviewboard.kde.org/r/129275/diff/ Testing ------- jobtest still passes (with one expected failure). Thanks, Elvis Angelaccio
