> On Окт. 31, 2016, 12:38 преди обяд, David Faure wrote: > > src/core/kcoredirlister.h, line 429 > > <https://git.reviewboard.kde.org/r/129205/diff/3/?file=482930#file482930line429> > > > > You can't add virtual methods to a public class, this is not binary > > compatible.
That because it's added at last position in public scope, i wasn't sure to add it here or even after qsignals. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129205/#review100411 ----------------------------------------------------------- On Окт. 24, 2016, 10:05 преди обяд, Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129205/ > ----------------------------------------------------------- > > (Updated Окт. 24, 2016, 10:05 преди обяд) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > David, i will discard review if you don't like it, cause watching files > changes can be *really* expensive. I try to: > 1. to not break abi compability > 2. to extend filenamesearch with this option > 3. to fix https://git.reviewboard.kde.org/r/129141/ > > > Diffs > ----- > > src/core/kcoredirlister.h e6ba2ac > src/core/kcoredirlister.cpp 508516e > src/core/kcoredirlister_p.h 9a3cc7b > tests/kdirlistertest_gui.h 8316b20 > tests/kdirlistertest_gui.cpp 11e89cf > > Diff: https://git.reviewboard.kde.org/r/129205/diff/ > > > Testing > ------- > > For 3. i still can't figure out why in filenamesearch signal for delete > item(s) is not triggered. > 1. Search for file (by name) in dolphin > 2. When appear in view delete him > 3. Signal ItemsDeleted is not triggered, file stays in the view even if new > search is performed and reload is needed. The cache look good, tests pass, > works but in filenamesearch. > > > Thanks, > > Anthony Fieroni > >