> On Nov. 1, 2016, 2:35 a.m., Aleix Pol Gonzalez wrote: > > src/kxmlguiwindow.cpp, line 313 > > <https://git.reviewboard.kde.org/r/129299/diff/2/?file=483603#file483603line313> > > > > How come this is the _only_ exception? > > Albert Astals Cid wrote: > Because it's the only case where our StandardActions actually have > conflicts. DeleteFile vs EditCut > > Aleix Pol Gonzalez wrote: > If kxmlgui allows itself to have an exception, applications might > eventually also need such exceptions. > > Albert Astals Cid wrote: > I don't know what you mean, please explain what an application might want?
To create their own exceptions? I think it's weird that we have logic to detect only this case. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/#review100456 ----------------------------------------------------------- On Oct. 31, 2016, 8:18 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129299/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2016, 8:18 p.m.) > > > Review request for KDE Frameworks, David Faure and Elvis Angelaccio. > > > Repository: kxmlgui > > > Description > ------- > > Add a warning at the createGui stage about ambiguous shortcuts being found in > the same action collection. > > This is usually a developer issue, but the error message about ambiguity will > only show up when someone tries to use the shortcut, so it is relatively easy > to miss if you do not try all your actions via a shortcut. > > Also if the involved shortcut is one of the non primary shortcuts of > edit_cut, just give it away, since it's usually Shift+Delete being fought > over. > > > Diffs > ----- > > src/kxmlguiwindow.cpp 519fb26 > > Diff: https://git.reviewboard.kde.org/r/129299/diff/ > > > Testing > ------- > > gwenview now defaults to Shift+Delete being "Hard delete" and not "Cut", if > you remove the > if (action == editCutAction || existingShortcutAction == editCutAction) { > part, you get warning about the actions involved > > > Thanks, > > Albert Astals Cid > >
