----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129361/#review100712 -----------------------------------------------------------
cmake/FindUTEMPTER.cmake (line 43) <https://git.reviewboard.kde.org/r/129361/#comment67609> I think we shouldn't search in fixed path i.e. /usr/... ${CMAKE_PREFIX_PATH}/lib/${CMAKE_LIBRARY_ARCHITECTURE}/utempter So "patch" like above one is error prone - Anthony Fieroni On Nov. 8, 2016, 1:02 a.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129361/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2016, 1:02 a.m.) > > > Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter. > > > Repository: kpty > > > Description > ------- > > Read the summary > > > Diffs > ----- > > cmake/FindUTEMPTER.cmake d3236c8 > > Diff: https://git.reviewboard.kde.org/r/129361/diff/ > > > Testing > ------- > > Works > > > Thanks, > > Albert Astals Cid > >