----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129394/#review101007 -----------------------------------------------------------
filenamesearch/kded/filenamesearchmodule.cpp (line 84) <https://git.reviewboard.kde.org/r/129394/#comment67734> Well, if dirUrl looks like "filenamesearch:?search=file&url=file:///path/to/file" then dirUrl.path() is empty, and this code is incorrect (it should use the query item "url", not the path). What am I missing? - David Faure On Nov. 14, 2016, 11:44 a.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129394/ > ----------------------------------------------------------- > > Review request for KDE Frameworks, Anthony Fieroni, David Faure, and Emmanuel > Pescosta. > > > Repository: kio-extras > > > Description > ------- > > Bug is introduced in https://git.reviewboard.kde.org/r/129297/ > When is fixed new kio-extras realease is needed for 16.08 branch. > > > Diffs > ----- > > filenamesearch/kded/filenamesearchmodule.cpp 3f9f582 > > Diff: https://git.reviewboard.kde.org/r/129394/diff/ > > > Testing > ------- > > No big ram usage but still not works as expected. > 1. Perform search in Dolphin > 2. Delete one result item > 3. View must be update, but it's not > > > Thanks, > > Anthony Fieroni > >