> On Nov. 18, 2016, 8:05 p.m., Andreas Sturmlechner wrote: > > CMakeLists.txt, line 37 > > <https://git.reviewboard.kde.org/r/129426/diff/1/?file=485781#file485781line37> > > > > that looks to me as if it does the opposite as in $description; prefer > > the old one to the new one. > > Harald Sitter wrote: > You take offense with an if checking whether we can build with gpg > support? > > Andreas Sturmlechner wrote: > It does the opposite of what you say you want in the description. > Preferring the new lib is the status quo. > > Andreas Sturmlechner wrote: > And while I agree that the current approach can be much improved, > KF5Gpgmepp is not here to stay anyway. 16.08.3 is its final release and with > KF-5.30 it may as well be kicked out by simply reverting > 60ebcad53c95ecfbe822647075f79578c3420851 (which leaves the unnecessary > duplication in test dir). > > Harald Sitter wrote: > I don't understand. > > Jan Kundrát wrote: > Harald, I believe that Andreas is telling you that the review description > says "the new bindings from gpgme upstream are preferred over the legacy > kf5-gpgmepp", but the actual cmake code will select kf5-gpgmepp when both of > them are installed on the build machine.
AH! kf5gpgmepp is the old thing, I thought it was the other way around xD Easily fixed. - Harald ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129426/#review100933 ----------------------------------------------------------- On Nov. 18, 2016, 2 p.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129426/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2016, 2 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kwallet > > > Description > ------- > > refactor gpg finding code to be correctly taking all FOUND vars into account, > indicate itself as feature to cmake, prefer the new lib over the old one, not > be duplicated in runtime and test dir, not require excessively shitty if's to > be used. > > > Diffs > ----- > > CMakeLists.txt 6145fda8ebd8470024396b9029d1f23298d1a333 > src/runtime/kwalletd/CMakeLists.txt > 5092a7e77a1ca7203827e444c11310566b2cc8b5 > src/runtime/kwalletd/backend/CMakeLists.txt > 2f99bc3cca89dd7a194f46cb314d2f7f90f931f3 > tests/kwalletd/CMakeLists.txt 1e7c4b77ba478147fae964f61c28a736e32b9ea9 > > Diff: https://git.reviewboard.kde.org/r/129426/diff/ > > > Testing > ------- > > builds and continues to link to gpg > > > Thanks, > > Harald Sitter > >
