----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129657/ -----------------------------------------------------------
Review request for KDE Frameworks and Stephen Kelly. Repository: kitemmodels Description ------- After int proxyEndRemove = proxyStartRemove; proxyEndRemove += rc; was adding 0 (empty root) and then --proxyEndRemove; was making us end up with proxyEndRemove < proxyStartRemove. Diffs ----- autotests/kselectionproxymodeltest.cpp 483e7c42dabab6aa560622ff0418ee7f90363e15 src/kselectionproxymodel.cpp 0f57c70f05d4cbde9b14f4257bff1365ef5443f6 Diff: https://git.reviewboard.kde.org/r/129657/diff/ Testing ------- New unittest + unchecking calendar in korganizer no longer asserts. Thanks, David Faure