----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129628/#review101515 -----------------------------------------------------------
src/CMakeLists.txt (line 103) <https://git.reviewboard.kde.org/r/129628/#comment67954> It's already installed, see this line. No need to install it twice. - David Faure On Dec. 9, 2016, 1:28 a.m., José Manuel Santamaría Lema wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129628/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2016, 1:28 a.m.) > > > Review request for KDE Frameworks and Dan Leinir Turthra Jensen. > > > Repository: knewstuff > > > Description > ------- > > This patch installs a couple of missing headers: > > * knewstuffcore_export.h - which is #include'd from many files in > /include/KF5/KNewStuff3/knscore/ > * entry.h - this is #include'd from > /usr/include/KF5/KNewStuff3/knscore/entryinternal.h as "../entry.h" > > If the "entry.h" part of the patch is fine, maybe this commit should be > reverted: > https://cgit.kde.org/knewstuff.git/commit/?id=7a644d7147edb816b69fa973630cea6aa72bc3ef > > > Diffs > ----- > > src/CMakeLists.txt 79ef39b > src/core/CMakeLists.txt c2a1a24 > > Diff: https://git.reviewboard.kde.org/r/129628/diff/ > > > Testing > ------- > > I just ran a test from the kubuntu package meant to check that all the needed > headers are available. > > > Thanks, > > José Manuel Santamaría Lema > >