> On Dec. 21, 2016, 4 p.m., Christoph Feck wrote: > > Looks good so far, but see issues below. Please do not use C++11 features > > in library code yet (it's okey for tests). > > > > Regarding the 500 ms timeout, does it need to be configurable using a > > property? I am unsure how the interaction with the widget interferes with > > the 'hide' timeout.
If the mouse hovers the tooltip the hide timeout is stopped and the tooltip will stay visible. This allows interaction with the inner widget. The tooltip will be hidden as soon as the mouse leaves the window. About the timeout itself, yes I think that a property may be desiderable, after all 500ms is just a random value that I picked. - Elvis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/#review101534 ----------------------------------------------------------- On Dec. 20, 2016, 3:40 p.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129648/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2016, 3:40 p.m.) > > > Review request for KDE Frameworks, Ben Cooksley, Christoph Feck, and Martin > Gräßlin. > > > Repository: kwidgetsaddons > > > Description > ------- > > This new widget is based on the KToolTip code that is duplicated across > multiple products: at least Dolphin, systemsettings, kinfocenter, > ktp-contact-list. > > Rationale: with a single class in frameworks, it will be possible to apply > features/fixes only once. See for example the comments in > https://phabricator.kde.org/D3112 > > A new feature that the old code doesn't have is the delayed hide: this makes > it possible to actually use the widget shown in the tooltip. > > > Diffs > ----- > > autotests/CMakeLists.txt ffcce3a046ec98b07c4677578f6bc997de1ef16b > autotests/ktooltipwidgettest.h PRE-CREATION > autotests/ktooltipwidgettest.cpp PRE-CREATION > src/CMakeLists.txt de0a8d965f1541d5ffeec93d1aa06600b0b9c138 > src/ktooltipwidget.h PRE-CREATION > src/ktooltipwidget.cpp PRE-CREATION > tests/CMakeLists.txt fcb348b1ae9d4270468c3f9003c5ba5f3903db84 > tests/ktooltipwidget_test.h PRE-CREATION > tests/ktooltipwidget_test.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129648/diff/ > > > Testing > ------- > > Manual test works both in X11 and Wayland. Unit tests pass. > > Ported Dolphin locally to this new class, everything seems to work (and this > will fix bug [#352276](https://bugs.kde.org/show_bug.cgi?id=352276) and > [#371223](https://bugs.kde.org/show_bug.cgi?id=371223)). > > > Thanks, > > Elvis Angelaccio > >
