----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129715/#review101651 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On Dec. 28, 2016, 4:35 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129715/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2016, 4:35 p.m.) > > > Review request for KDE Frameworks. > > > Repository: frameworkintegration > > > Description > ------- > > * add a positive and negative test > * makes sure exiting event loops won't close the application > * Adopts a realistic approach for the providerId. It used to compare the > whole url, which can't realistically be part of the URL path, now just tests > the hostname. > * Port to KNewStuffCore, to reduce entropy > > > Diffs > ----- > > src/kpackage-install-handlers/kns/CMakeLists.txt 3f31f7f > src/kpackage-install-handlers/kns/main.cpp 7f1784d > > Diff: https://git.reviewboard.kde.org/r/129715/diff/ > > > Testing > ------- > > Manually tested > > > Thanks, > > Aleix Pol Gonzalez > >