Re: Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins

[Stefan Brüns]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129720/#review102096
-----------------------------------------------------------




src/extractorcollection.cpp (line 155)
<https://git.reviewboard.kde.org/r/129720/#comment68240>

    This is broken:
    
    if (plugins.isEmpty()) {
      ...
      for (; it != d->m_extractors.constEnd(); it++) {
         if (plugins.contains( some_value )
    
    The "plugins.contains(...)" is always false.


- Stefan Brüns


On Dec. 29, 2016, 7:17 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129720/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2016, 7:17 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> -------
> 
> startsWith is a weak precondition + guard for duplicate plugin
> 
> 
> Diffs
> -----
> 
>   src/extractorcollection.cpp d0fbbea 
> 
> Diff: https://git.reviewboard.kde.org/r/129720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>