> On Ян. 29, 2017, 8:02 след обяд, Albert Astals Cid wrote: > > This patch makes no sense (somehow you wait for two shows to happen) and > > you even have tried it where it makes sense so -1
You can see the logic is only inverted to main, your comment makes no sense to me. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129885/#review102318 ----------------------------------------------------------- On Ян. 29, 2017, 8:25 след обяд, Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129885/ > ----------------------------------------------------------- > > (Updated Ян. 29, 2017, 8:25 след обяд) > > > Review request for KDE Frameworks, Albert Astals Cid and David Faure. > > > Repository: kconfigwidgets > > > Description > ------- > > This patch (https://git.reviewboard.kde.org/r/129261/) is *ugly* makes side > effects on KDE menubars. Start Dolphin -> hide menubar -> restart it -> click > control button -> menubar action is checked. > It hide all actions changed between updateAction calls e.g. > updateAction (stores last state of checked and enable) > application changed menu action like it want > updateAction is called on show event -> discard modified states > > > Diffs > ----- > > src/kstandardaction.cpp 6e5bba7 > > Diff: https://git.reviewboard.kde.org/r/129885/diff/ > > > Testing > ------- > > Works correct on KDE, test it on Unity. > Please don't make such a patch, respect application behavior. > > > Thanks, > > Anthony Fieroni > >
