flherne created this revision. flherne added a reviewer: KTextEditor. flherne set the repository for this revision to R39 KTextEditor. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks.
REVISION SUMMARY Reverse meaning of :split, :vsplit to match vi and Kate actions. The previous behaviour of these commands was swapped, compared either to vi or to "Split Vertical" in Kate. :new and :vnew were fixed in https://phabricator.kde.org/R39:0b00782a90ec1d68b0fe0f3140620aeb6de4b132, but this pair was missed. Given that every use I can find has this confusing reverse pattern, the API is probably wrong. Too late now. Pointed out by head7 in https://phabricator.kde.org/D4250. TEST PLAN Compiles, matches vi now. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4421 AFFECTED FILES src/vimode/appcommands.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: flherne, #ktexteditor Cc: kwrite-devel, #frameworks
