----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129943/#review102511 -----------------------------------------------------------
Ship it! Thanks, I committed the patch with minor some changes. - Christoph Feck On Feb. 12, 2017, 3:16 p.m., DaeHyun Sung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129943/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2017, 3:16 p.m.) > > > Review request for KDE Frameworks, Christoph Feck and Eike Hein. > > > Repository: kwidgetsaddons > > > Description > ------- > > # Add Hangul jamo representation for Hangul Syllables on KDE kcharselect > > [Proposal, Enhancement] Add Hangul jamo representation for Hangul Syllables > on KDE kcharselect > > This is not bug, but I think that feature enhance KDE kcharselect for Korean > learners and Korean users. > > I add new feature, “Add Hangul jamo representation for selected Hangul > Syllables features on KDE kcharselect” > > Hangul elements are commonly referred to as jamo(??/??), meaning “alphabet” > > Korean has special term for the jamo that are used to construct hangul > syllable, depending on where in the syllable they appear: > - Choseong(??/??) for the initial sound, usually a consonant > - Jungseong(??/??) for the middle sound, usually a vowel > - Jongseong(??/??) for the final sound, usually a consonant > > > Examples of Canonical Equivalence > Hangul & conjoining jamo ? ? ? +? > > > Hangul syllables are the characters that are used to express contemporary > Korean texts in writing. > > KDE kcharselect canonical decomposition Notation not appear Hangul jamo for > Selected Hangul syllable. > so I add “Hangul jamo names and representation for selected hangul syllable” > feature on KDE kcharselect. > example) > Hangul Syllable decomposition: > > * ? U+1100 HANGUL CHOSEONG KIYEOK > * ? U+1161 HANGUL JUNGSEONG A > > > ex1) Decomposition of hangul syllable > Unicode codepoint: U+AC00 > Hangul(??) ‘?’ > jamo(??/??): ? plus ? > choseong(??/??): ? (codepoint: U+1100) > jungseong(??/??): ?(codepoint: U+1161) > > Selected Hangul syllable ‘?’(U+AC00) > TO-BE > Hangul Syllable decomposition: > > * ? U+1100 HANGUL CHOSEONG KIYEOK > * ? U+1161 HANGUL JUNGSEONG A > > > ex2) Decomposition of hangul syllable > Unicode code point: U+AC01 > Hangul(??) ‘?’ > jamo(??/??): ‘?’ plus ‘?’ plus ‘?’ > choseong(??/??):? (codepoint: U+1100) > jungseong(??/??):?(codepoint: U+1161) > jongseong(??/??):? (codepoint: U+11A8) > > > Selected Hangul syllable ‘?’(U+AC01) > TO-BE > Hangul Syllable decomposition: > > * ? U+1100 HANGUL CHOSEONG KIYEOK > * ? U+1161 HANGUL JUNGSEONG A > * ? U+11A8 HANGUL JONGSEONG KIYEOK > > ex3) Decomposition of hangul syllable > Unicode code point: U+C633 > Hangul(??) ‘?’ > jamo(??/??): ‘?’ plus ‘?’ plus ‘?’ > choseong(??/??):? (codepoint: U+110B) > jungseong(??/??):?(codepoint: U+1169) > jongseong(??/??):? (codepoint: U+11B6) > > Selected Hangul syllable ‘?’ (U+C633) > TO-BE > Hangul Syllable decomposition: > > * ? U+110B HANGUL CHOSEONG IEUNG > * ? U+1169 HANGUL JUNGSEONG O > * ? U+11B6 HANGUL JONGSEONG RIEUL-HIEUH > > > Reference > KS X 1026-1:2007 Information Technology - Universal Multiple-Octet Coded > Character Set(UCS) - Hangul > Part1 Hangul processing guide for information interchanges > http://std.dkuug.dk/jtc1/sc2/wg2/docs/n3422.pdf > > Unicode Normalization forms http://unicode.org/reports/tr15/ > Unicode Normalization forms #14.1.4. Hangul Decomposition and Composition > http://unicode.org/reports/tr15/#Hangul_Composition > Hangul Jamo (Range: U+1100-U+11FF) > http://www.unicode.org/charts/PDF/U1100.pdf > Hangul Syllables (Range: U+AC00-U+D7AF) > http://www.unicode.org/charts/PDF/UAC00.pdf > > > Diffs > ----- > > src/kcharselect.cpp cee6efc > src/kcharselectdata.cpp 724a374 > src/kcharselectdata_p.h 6c07c7e > > Diff: https://git.reviewboard.kde.org/r/129943/diff/ > > > Testing > ------- > > > Thanks, > > DaeHyun Sung > >