----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129955/#review102534 -----------------------------------------------------------
Ship it! Good catch! I was curious and look a bit about it, turns out you are correct. :) (also crappy API...) - Aleix Pol Gonzalez On Feb. 17, 2017, 12:23 a.m., Damjan Georgievski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129955/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2017, 12:23 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kwallet-pam > > > Description > ------- > > from the snprintf man page: > > The functions snprintf() and vsnprintf() do not write more than size bytes > (*including* the terminating null byte ('\0')). If > the output was truncated due to this limit, then the return value is the > number of characters (*excluding* the terminating null > byte) which would have been written to the final string if enough space had > been available. Thus, a return value of size or > more means that the output was truncated. > > pam_wallet.c should increase the needed parameter by one, to account for the > terminating null byte ('\0') > > > Diffs > ----- > > pam_kwallet.c c89bf6d > > Diff: https://git.reviewboard.kde.org/r/129955/diff/ > > > Testing > ------- > > > Thanks, > > Damjan Georgievski > >
