> On Oct. 20, 2016, 11:49 a.m., Albert Astals Cid wrote: > > Unfortunately the patch does not apply anymore since we forgot to commit it > > and someone did part of the work, could you upload a new version of it that > > applies against current master?
If this is not updated in 3 months i'll discard it to try to keep the queue cleaner. - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120458/#review100168 ----------------------------------------------------------- On Oct. 4, 2014, 5:31 p.m., Maarten De Meyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120458/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2014, 5:31 p.m.) > > > Review request for KDE Frameworks. > > > Bugs: 339456 > https://bugs.kde.org/show_bug.cgi?id=339456 > > > Repository: kio-extras > > > Description > ------- > > We need QApplication for KWebPage. > Store thumbnails created by directory thumbnailer with the correct name. > I also enabled the desktop thumbnailer, it uses textcreator. > > note: I still need to port thumbnail.cpp away from KDE4support > > > Diffs > ----- > > CMakeLists.txt 2036392 > thumbnail/CMakeLists.txt 4c2d5e9 > thumbnail/djvucreator.cpp 1035b98 > thumbnail/htmlcreator.cpp ea553f0 > thumbnail/thumbnail.cpp d4a7f35 > > Diff: https://git.reviewboard.kde.org/r/120458/diff/ > > > Testing > ------- > > Thumbnails work. > djvu and html only tested with a single file each. It would be great if > somebody with a big collection of these files could check for regressions. > > > Thanks, > > Maarten De Meyer > >
