mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in framesvgitem.cpp:571-574
> this !found is a behavioural change on the existing code.
>
> Why are we adding it?
before it did set the elementprefix on the framesvg regardless it was present
or not, so this is done in order precisely to not do a behavioral change.
to be more exact to be sure no behavioral change occurred at all, i would have
to do
if (!found) {
m_frameSvg->setElementPrefix(m_prefixes.last());
}
which if doesn't exist, is pretty much the same as setting an empty string, but
i can change it to do so
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4827
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, #frameworks, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol
