kfunk closed this revision.
kfunk added a comment.

  Closing. Please just strip the flag from CMake flags if you're using a 
library making use of alternative tokens.
  
  We've just seen compilation failing early because some lib in KF5 
accidentally used alternative tokens => would have broken compilation on 
Windows again. So in one regard this is really good to have in place. I didn't 
receive any more complaints about this patch so far.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D3850

To: kfunk, #frameworks, #build_system, ivan
Cc: nalvarez, thomasp, rakuco, elvisangelaccio

Reply via email to