----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128159/#review102950 -----------------------------------------------------------
Not using "Create" with the setupGUI() call though ran across the initial idea of this patch, as now setXMLFile() is no longer called implicitly when the "Create" flag is not passed to setupGUI() :) Filed https://phabricator.kde.org/D5181 to fix this up. - Friedrich W. H. Kossebau On June 13, 2016, 5:17 p.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128159/ > ----------------------------------------------------------- > > (Updated June 13, 2016, 5:17 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kparts > > > Description > ------- > > KXMLGui-based apps should always use `setupGUI()`, which has several > advantages over `setXMLFile()` and calls it implicitly. > > This patch also adds a code snippet about this. > > > Diffs > ----- > > src/mainwindow.h b672a35cba92475200ff15620a21150da19582dd > > Diff: https://git.reviewboard.kde.org/r/128159/diff/ > > > Testing > ------- > > > Thanks, > > Elvis Angelaccio > >
