mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:45
>  
> -    DESTINATION ${KDE_INSTALL_QMLDIR}/org/kde/plasma/components.3)
> +    DESTINATION ${KDE_INSTALL_QMLDIR}/org/kde/plasma/components/3)

components.3 is actually what is searched for by the import system when 
importing  a versioned import (kirigami is doing this as well)

> qmldir:39
> +
> +BusyIndicator 3.0 3/BusyIndicator.qml
> +Button 3.0 3/Button.qml

the components.3 folder should have its own qmldir instead

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5603

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

Reply via email to