intelfx added a comment.
In https://phabricator.kde.org/D5802#109416, @mwolff wrote: > For solarized you showed the screenshots in your original mail. I'm more concerned about backwards compatibility with other schemes. I.e. yes - we do care about the status quo. Can you give an example for a color scheme where this would break stuff? Then I can also apply the patch locally and try it out myself and maybe come up with a concrete idea to fix this all. OK — take a look at the attached screenshots (I hope Phabricator will preserve their names). F3752512: KDevelop-Vim (dark)-Before.png <https://phabricator.kde.org/F3752512> F3752511: KDevelop-Vim (dark)-After.png <https://phabricator.kde.org/F3752511> F3752510: KDevelop-Printing-Before.png <https://phabricator.kde.org/F3752510> F3752509: KDevelop-Printing-After.png <https://phabricator.kde.org/F3752509> F3752508: KDevelop-Normal-Before.png <https://phabricator.kde.org/F3752508> F3752507: KDevelop-Normal-After.png <https://phabricator.kde.org/F3752507> F3752506: KDevelop-KDE-Before.png <https://phabricator.kde.org/F3752506> F3752505: KDevelop-KDE-After.png <https://phabricator.kde.org/F3752505> F3752504: KDevelop-Breeze Dark-Before.png <https://phabricator.kde.org/F3752504> F3752503: KDevelop-Breeze Dark-After.png <https://phabricator.kde.org/F3752503> So, basically, Normal and Printing are broken because they are explicitly designed for old behavior. Breeze-Dark and Vim-dark do not care because they have selection foreground == normal foreground. > Also, can you then share your solarized theme? Please find attached in form of rc files (append them to your kateschemarc/katesyntaxhighlightingrc, I've stripped all other color schemes). F3752527: katesyntaxhighlightingrc <https://phabricator.kde.org/F3752527> F3752526: kateschemarc <https://phabricator.kde.org/F3752526> REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5802 To: intelfx, #kdevelop, #ktexteditor, #kate Cc: mwolff, kwrite-devel, #frameworks
