kfunk added a comment.
LGTM in general. I'll hope to find some time to test on Window, wouldn't want
this to be merged before that.
INLINE COMMENTS
> KDECompilerSettings.cmake:226
> + if (MSVC)
> + if (${MSVC_VERSION} GREATER 1900)
> + # /permissive- became the preferred switch to obtain
> standards-compliant
`MSVC_VERSION GREATER 1900` is sufficient. No need for `${...}`
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5865
To: rjvbb, #frameworks, #build_system, cgilles
Cc: kfunk
